[Visual Refresh] Add behindText vis color tokens#8253
Merged
mgadewoll merged 2 commits intoelastic:eui-theme/borealisfrom Jan 7, 2025
Merged
Conversation
mgadewoll
added
skip-changelog
mgadewoll
force-pushed
the
eui-theme/borealis-behind-text-tokens
branch
from
755606d to
7528314
Compare
packages/eui-theme-common/src/global_styling/variables/colors.ts
Outdated
Show resolved
Hide resolved
packages/eui/src/themes/amsterdam/global_styling/variables/_colors_vis.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
ℹ️ FYI I realized we have a breaking test due to the new year. I added the fix here on I'll add the fix to this PR to be able to add the changes, but I will wait until the actual fix PR is reviewed and merged to rebase Borealis. |
mgadewoll
force-pushed
the
eui-theme/borealis
branch
from
615e56b to
d1e1f1c
Compare
mgadewoll
force-pushed
the
eui-theme/borealis-behind-text-tokens
branch
from
67971c8 to
e1109c1
Compare
Contributor
Author
ℹ️ I rebased this branch with the updated Borealis feature branch that includes the test pipeline fix. |
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
weronikaolejniczak
approved these changes
Jan 7, 2025
7 tasks
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Jan 20, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
This PR adds
_behindTextvis color tokens. These have not been part of the theme, as they are not in usage in the new theme.During upgrades to the new theme, we realized that it's rather cumbersome for teams to migrate these JSON token usages properly to the
euiThemetokens without a 1:1 equivalent.These tokens are temporary for the purpose of making migration easier for Kibana teams. We will need to remove those tokens again at some point as they are not be used in Borealis.
QA
These tokens are not used anywhere. Make sure the values make sense:
Amsterdam - uses values returned from
euiPaletteColorBlindBehindText()Borealis maps to default vis colors
CI passes